`validate` throws a TypeError: Cannot read properties of undefined (reading 'type')

[matthew-wozniczka]

graphql-js/src/validation/rules/ValuesOfCorrectTypeRule.ts

Line 219 in c18e9f6

const isNullableVariable = definition.type.kind !== Kind.NON_NULL_TYPE;

I've hit a TypeError being thrown from this line when testing against some invalid queries.

I'm not using this library directly, but instead via https://github.com/apollographql/apollo-server (4.12.2), so maybe I should report it there, let me know if so. It's not really easy to provide a reproducer at this level either, so maybe that's another signal...

[yaacovCR]

This seems like a legitimate bug in our one-of validation, the variable definition is missing, our rule assumes spec-wise that this has been validated elsewhere, so we should presumably just stop validation rather than just crash. :)

What version of graphql-js are you on, btw?

[matthew-wozniczka]

I'm using 16.11.0