-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flow + "@flow strict" #1229
Conversation
I merged in the new flow version, but we don't need to use strict pragmas since we're not using the strict linter yet. The new flow version now tracks const args, but doesn't enforce them like you can enable as a strict linter |
I was wrong - it seems the strict mode adds additional checks in addition to applying the linter |
@leebyron Thanks for merge. graphql-js/src/type/introspection.js Lines 467 to 476 in 5fe3926
It was introduced in #1160 because you reverted |
It's such a pain to not be able to function args inside arrow functions, but the new version of Flow introduced
@flow strict
that makes function arguments constant.Since
@flow strict
don't rely on.flowconfig
it shouldn't cause the problem described in #1157.It's a huge DX improvement for me since I spend 5-10 minutes debugging every time Flow is not able to figure out the type of function argument.