Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extendSchema: Use consistent naming + inline 'getExtendedType' func #1327

Merged
merged 1 commit into from
May 14, 2018

Conversation

IvanGoncharov
Copy link
Member

Based on this discussion: #1322 (comment)
I think naming should be consistent with types and predicates:

export function isType(type: mixed): boolean %checks {
return (
isScalarType(type) ||
isObjectType(type) ||
isInterfaceType(type) ||
isUnionType(type) ||
isEnumType(type) ||
isInputObjectType(type) ||
isListType(type) ||
isNonNullType(type)
);
}

export function isNamedType(type: mixed): boolean %checks {
return (
isScalarType(type) ||
isObjectType(type) ||
isInterfaceType(type) ||
isUnionType(type) ||
isEnumType(type) ||
isInputObjectType(type)
);
}

@leebyron
Copy link
Contributor

Makes sense to me - do you mind rebasing?

@IvanGoncharov
Copy link
Member Author

@leebyron Rebased

@mjmahone mjmahone merged commit 0276d68 into graphql:master May 14, 2018
@mjmahone
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants