Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage: Switch isparta to nyc #1342

Merged
merged 1 commit into from
May 11, 2018

Conversation

IvanGoncharov
Copy link
Member

Isparta produces incorrect coverage reports:
image

Moreover there is zero chance it will be fixed since isparta is officially unmantained.
So I switched isparta to nyc which is official CLI for istanbul and also replaced babel-node workaround with offically recomended babel-registry/babel-polyfill.

Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL coverage report libraries exist.

@mjmahone mjmahone merged commit 2592e12 into graphql:master May 11, 2018
@IvanGoncharov IvanGoncharov deleted the simplifyScripts branch May 14, 2018 10:43
@leebyron
Copy link
Contributor

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants