Flow: fix errors in 'flatMap.js' on old Flow versions #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: bug fix 🐞
IvanGoncharov
commented
Aug 27, 2019
| @@ -5,11 +5,14 @@ declare function flatMap<T, U>( | |||
| fn: (item: T, index: number) => $ReadOnlyArray<U> | U, | |||
| ): Array<U>; | |||
|
|
|||
| // Workaround to make older Flow versions happy | |||
| const flatMapMethod = (Array.prototype: any).flatMap; | |||
There was a problem hiding this comment.
@jedwards1211 We enabled Flow warnings in config:
Line 35 in 8ab6524
So flow generate warnings for ignored
$FlowFixMe.It also possible that other projects using
include_warnings=trueSo I decided to just use
any since it works in all Flow versions.
There was a problem hiding this comment.
Gotcha, yeah the fact that ignore comments may not work when the package is used as a dependency is a real shortcoming of Flow right now
There was a problem hiding this comment.
I released 14.5.4 📦 with this fix included.
Sorry for the delay.
This was referenced Sep 7, 2019
Merged
This was referenced Oct 26, 2019
This was referenced Feb 12, 2020
This was referenced Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2136