Consistent error messages in buildClientSchema #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always: - put a space after : - terminate with a .
|
@spawnia Not sure why Travis doesn't update status but build is broken on this PR: |
|
I went all in on template strings and extracted where needed to keep the line count low and prettier happy. |
IvanGoncharov
added
the
PR: polish 💅
# Conflicts: # src/utilities/buildClientSchema.js
|
@IvanGoncharov Resolved the conflicts and modified the PR according to your suggestions. |
|
@spawnia Merged 🎉 |
This was referenced Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always: