Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for long deprecated comments as descriptions #2900

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Jan 27, 2021
@IvanGoncharov IvanGoncharov merged commit ec2352a into graphql:main Jan 31, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch January 31, 2021 11:56
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Feb 20, 2021
@jonathanstanley
Copy link

Just to clarify in case others come here trying to resolve their lost comments: GraphQL differentiates between "descriptions" and "comments"

Here is a good resource on the topic: graphql/graphql-spec#420

GeoffreyHervet added a commit to GeoffreyHervet/type-graphql that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants