Preserve sources of variable values #3077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
leebyron
force-pushed
the
variable-value-sources
branch
2 times, most recently
from
a271cab to
fdb733e
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
2ee1da8 to
330f01a
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
fdb733e to
6cecfdd
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
330f01a to
05db9bd
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
6cecfdd to
abdec72
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
05db9bd to
6c79c53
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
abdec72 to
7e9ce87
Compare
leebyron
force-pushed
the
default-value-literals
branch
3 times, most recently
from
13e3148 to
780cec2
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
7e9ce87 to
ece9e18
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
780cec2 to
5686d3e
Compare
leebyron
force-pushed
the
variable-value-sources
branch
2 times, most recently
from
f34abdd to
4b8c50a
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
5686d3e to
705f154
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
4b8c50a to
b967e71
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
705f154 to
dd31191
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
b967e71 to
14d3f8d
Compare
leebyron
force-pushed
the
default-value-literals
branch
2 times, most recently
from
448367e to
e2002dc
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
14d3f8d to
25ec49a
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
e2002dc to
5601fd4
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
25ec49a to
0c65c4d
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
5601fd4 to
3110ca1
Compare
leebyron
force-pushed
the
variable-value-sources
branch
from
0c65c4d to
cbf56f0
Compare
leebyron
force-pushed
the
default-value-literals
branch
from
3110ca1 to
f1a14c6
Compare
By way of introducing type `VariableValues`, allows `getVariableValues` to return both the coerced values as well as the original sources, which are then made available in `ExecutionContext`.
leebyron
force-pushed
the
variable-value-sources
branch
from
cbf56f0 to
6fea731
Compare
This was referenced Dec 31, 2022
yaacovCR
added a commit
that referenced
this pull request
Sep 29, 2024
[#3077 rebased on main](#3077). Depends on #3810 @leebyron comments from original PR: > By way of introducing type `VariableValues`, allows `getVariableValues` to return both the coerced values as well as the original sources, which are then made available in `ExecutionContext`. > > While variable sources are not used directly here, they're used directly in #3065. This PR is pulled out as a pre-req to aid review --------- Co-authored-by: Lee Byron <lee.byron@robinhood.com>
|
Merged as #3811 |
yaacovCR
added a commit
that referenced
this pull request
Oct 27, 2024
[#3049 rebased on main](#3049). This is the last rebased PR from the original PR stack concluding with #3049. * Rebased: #3809 [Original: #3092] * Rebased: #3810 [Original: #3074] * Rebased: #3811 [Original: #3077] * Rebased: #3812 [Original: #3065] * Rebased: #3813 [Original: #3086] * Rebased: #3814 (this PR) [Original: #3049] Update: #3044 and #3145 have been separated from this stack. Changes from original PR: 1. `astFromValue()` is deprecated instead of being removed. @leebyron comments from #3049, the original PR: > Implements [graphql/graphql-spec#793](graphql/graphql-spec#793) > > * BREAKING: Changes default values from being represented as an assumed-coerced "internal input value" to a pre-coerced "external input value" (See chart below). > This allows programmatically provided default values to be represented in the same domain as values sent to the service via variable values, and allows it to have well defined methods for both transforming into a printed GraphQL literal string for introspection / schema printing (via `valueToLiteral()`) or coercing into an "internal input value" for use at runtime (via `coerceInputValue()`) > To support this change in value type, this PR adds two related behavioral changes: > > * Adds coercion of default values from external to internal at runtime (within `coerceInputValue()`) > * Removes `astFromValue()`, replacing it with `valueToLiteral()` for use in introspection and schema printing. `astFromValue()` performed unsafe "uncoercion" to convert an "Internal input value" directly to a "GraphQL Literal AST", where `valueToLiteral()` performs a well defined transform from "External input value" to "GraphQL Literal AST". > * Adds validation of default values during schema validation. > Since assumed-coerced "internal" values may not pass "external" validation (for example, Enum values), an additional validation error has been included which attempts to detect this case and report a strategy for resolution. > > Here's a broad overview of the intended end state: > >  --------- Co-authored-by: Lee Byron <lee@leebyron.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3074
By way of introducing type
VariableValues, allowsgetVariableValuesto return both the coerced values as well as the original sources, which are then made available inExecutionContext.While variable sources are not used directly here, they're used directly in #3065. This PR is pulled out as a pre-req to aid review