Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid relying on constructor.name for instanceOf error check. #3172

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Avoid relying on constructor.name for instanceOf error check. #3172

merged 1 commit into from
Jun 13, 2021

Conversation

IvanGoncharov
Copy link
Member

Fixes #2894

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Jun 13, 2021
@IvanGoncharov IvanGoncharov merged commit 58122ef into graphql:main Jun 13, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch June 13, 2021 17:25
@IvanGoncharov IvanGoncharov mentioned this pull request Jun 14, 2021
Closed
1 task
@tubbo tubbo mentioned this pull request Jun 17, 2021
Merged
tubbo added a commit to tubbo/graphql-js that referenced this pull request Jun 17, 2021
@tubbo
Backport instanceOf Error Check Improvements
4fdaade 
This backports graphql#3172 to the `15.x.x` branch so that users of GraphQL
v15.x can take advantage of it. GraphQL v16.x has some breaking changes
and is not possible to run when you have other libraries depending on
the behavior of v15, such as GraphQL Code Generator.
IvanGoncharov pushed a commit to tubbo/graphql-js that referenced this pull request Jun 20, 2021
@tubbo @IvanGoncharov
Backport instanceOf Error Check Improvements
7b724c7 
This backports graphql#3172 to the `15.x.x` branch so that users of GraphQL
v15.x can take advantage of it. GraphQL v16.x has some breaking changes
and is not possible to run when you have other libraries depending on
the behavior of v15, such as GraphQL Code Generator.
benjamn pushed a commit to apollographql/react-apollo-error-template that referenced this pull request Jun 23, 2021
@dependabot
Bump graphql from 15.5.0 to 15.5.1 (#53)
94b7041 
Includes @benjamn's PR graphql/graphql-js#3172,
backported to 15.5.1 by graphql/graphql-js#3186.
@phryneas phryneas mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IvanGoncharov