Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message that we only support TS >= 4.1.0 #3319

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Add message that we only support TS >= 4.1.0 #3319

merged 1 commit into from
Oct 18, 2021

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Oct 18, 2021
@IvanGoncharov IvanGoncharov merged commit 7c6bf48 into graphql:main Oct 18, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch October 18, 2021 11:52
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Oct 19, 2021
@yaacovCR @IvanGoncharov
Merge latest graphql through 16.0.0-rc.5 (#30)
43faf00 
* Export OperationTypeNode as value (graphql#3316)

* Convert const "enum-like" maps to TS enums (graphql#3317)

* Deprecate 'ASTKindToNode' (graphql#3318)

* Add message that we only support TS >= 4.1.0 (graphql#3319)

* Update deps (graphql#3320)

* 16.0.0-rc.5

* Update lockfile

* change TODO

* Prune unused files

* Fix lockfile

* Add changeset

* fix lockfile

* spelling!

Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
ardatan
ardatan reviewed Oct 26, 2021
View reviewed changes
package.json
"*": [
"index.d.ts"
],
"*/*": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the nested imports and redirects all of them to index.d.ts. Now it is not possible to import Parser or some other stuff from the internals.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardatan Released https://github.com/graphql/graphql-js/releases/tag/v16.0.0-rc.7
can you please test it?
Also added an integration test for it, so it shouldn't happen again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanGoncharov Thanks! I'll write the results here

@IvanGoncharov
Copy link
Member Author

@ardatan Thanks for the report I will fix it before release.

@saihaj
Copy link
Member

saihaj commented Oct 27, 2021 •
edited
Loading

Kinda curious @IvanGoncharov why this was added? We don't publish or support types for different TS versions. This also forces projects to just use the TS version that this library supports.

saihaj added a commit that referenced this pull request Oct 27, 2021
@saihaj
Revert "Add message that we only support TS >= 4.1.0 (#3319)"
982a701 
This reverts commit 7c6bf48.
@saihaj saihaj mentioned this pull request Oct 27, 2021
Closed
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Oct 27, 2021
@IvanGoncharov
Fix TS error caused by importing internal files directly
c9180df 
Fixes graphql#3338
Caused by graphql#3319
@IvanGoncharov IvanGoncharov mentioned this pull request Oct 27, 2021
Merged
@IvanGoncharov
Copy link
Member Author

@saihaj Unanswered here: #3338 (comment)

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Nov 1, 2021
@yaacovCR @IvanGoncharov @Cito
Update dependencies (#50)
9e9653f 
* Export OperationTypeNode as value (graphql#3316)

* Convert const "enum-like" maps to TS enums (graphql#3317)

* Deprecate 'ASTKindToNode' (graphql#3318)

* Add message that we only support TS >= 4.1.0 (graphql#3319)

* Update deps (graphql#3320)

* 16.0.0-rc.5

* jsutils: add test for Path functions (graphql#2478)

Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>

* lexer: fix expression to decode surrogate pairs (graphql#3278)

* Lexer: use standard JS functions to handle Unicode (graphql#3322)

* GraphQLError-test: merge check of source with rest of the properties (graphql#3324)

* GraphQLError: fix empty `locations` if error got nodes without locations (graphql#3325)

* GraphQLError: enumerate only spec prescribed properties (graphql#3326)

* GraphQLField: relax default value of TArgs to `any` (graphql#3328)

* 16.0.0-rc.6

* Fix release instructions (graphql#3329)

* use GITHUB_TOKEN (graphql#3330)

* GraphQLError: Add test to check order of fields in JSON.stringify (graphql#3336)

* Fix TS error caused by importing internal files directly (graphql#3339)

* Use default GITHUB_ACTOR if unset (graphql#3331)

Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>

* 16.0.0-rc.7

* version: force proper typing on version literals

Types should be generic and stay the same across different versions
E.g. `preReleaseTag` should be typed `string | null` even if it's a
`null` literal for this particular release

* build-npm: fix type inference during TS declarations build

* version-test: fix validation of `versionInfo.preReleaseTag` (graphql#3345)

* 16.0.0

* checkgit.sh: Added a check for local modifications (graphql#3347)

* GraphQLError-test: text how extensions is inherited from originalError (graphql#3348)

* fix lockfile

* update graphql version

* Remove unused upstream file

* Upgrade deps

* add changeset

Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
Co-authored-by: Christoph Zwerschke <cito@online.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj left review comments

@ardatan ardatan ardatan left review comments

Assignees
No one assigned
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanGoncharov @saihaj @ardatan