-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new 'GraphQLSchema.getField' method #3605
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cc @yaacovCR |
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
This comment has been minimized.
This comment has been minimized.
@IvanGoncharov Please, see benchmark results here: https://github.com/graphql/graphql-js/runs/6598090837?check_suite_focus=true#step:6:1 |
Sadly, I need to figure out a way to run benchmark reliably on CI after #3604 So performance slightly increases by ~1% due to using a switch instead of multiple |
Motivation: generalize it and remove code dublication in two places and also allow to use as public API outside of graphql-js
Because this PR contains two changes ie change to switch and addition of unnecessary check for unions during execution, the benchmark results are not so accurate. i have suggested adding two helpers. See #3519 (comment) getObjectField and getCompositeField maybe? |
Motivation: generalize it and remove code dublication in two places and
also allow to use as public API outside of graphql-js