benchmark: replace failing on context switching with warning #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
cc: @yaacovCR |
yaacovCR
reviewed
Jun 2, 2022
yaacovCR
previously approved these changes
Jun 2, 2022
Consequently failed measurements due to context switches are bad. It mean something is bad with our setup: * Our test are taking too long to run (e.g. due to `count` being too big) * Machine that we measure on is doing some heave background task. * Some other factors, that are hard to predict. Currently, it's easy to solve this issue locally just by disabling background task on your machine, but it is non-trivial task to solve on CI.
IvanGoncharov
force-pushed
the
kindOnTypes
branch
from
f84e5cc to
f8c271a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consequently failed measurements due to context switches are bad.
It mean something is bad with our setup:
countbeing toobig)
Currently, it's easy to solve this issue locally just by disabling
background task on your machine, but it is non-trivial task to solve on
CI.