Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move subscribe code to execute file #3636

Merged
merged 2 commits into from
Jun 12, 2022
Merged

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Jun 10, 2022

= makes no other changes
= paves the way for further changes

@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit a584f25
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/62a61fa97548fd0008f3d1dc
😎 Deploy Preview https://deploy-preview-3636--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov
Copy link
Member

@yaacovCR Thanks a lot for doing it as a separate step 👍
Save a lot of effort during the review!
Changes look good once you remove the "positional test".
If you find that some popular libraries were using our "internal" functions please open a separate issue to discuss what to do and communicate with their authors.
Otherwise this PR is ready to be merge 👍

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 10, 2022
yaacovCR added 2 commits June 12, 2022 20:09
to preserve history for further integration
revert changes to exported functions
@yaacovCR yaacovCR merged commit e24f426 into graphql:main Jun 12, 2022
@yaacovCR yaacovCR deleted the move-subs branch June 12, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants