ESLint: error on function accepting more than 5 parameters #3641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We constantly have issues with public functions that overgrow this limit, e.g. execute/subscribe/graphql, GraphQLError, etc. Solving it afterwards create a long and problematic deprecation/migration path toward "named arguments", so this PR adds early warning of that problem. Note: ESLint doesn't have mechanism to enforce it only on exported functions so we need to apply this restriction on internal functions. But I actually think it's also make sense in a long run, since we frequently requested by community to make some of internal functions public.
IvanGoncharov
added
the
PR: polish 💅
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We constantly have issues with public functions that overgrow this
limit, e.g. execute/subscribe/graphql, GraphQLError, etc.
Solving it afterwards create a long and problematic
deprecation/migration path toward "named arguments", so this PR adds
early warning of that problem.
Note: ESLint doesn't have mechanism to enforce it only on exported
functions so we need to apply this restriction on internal functions.
But I actually think it's also make sense in a long run, since we
frequently requested by community to make some of internal functions public.