Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'assertValidExecutionArguments' function #3643

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Jun 13, 2022

After we drop runtime type checks that were duplicating TS types in #3642
this function became a wrapper for 'assertValidSchema' so all clients
that rely on it can now use 'assertValidSchema' directly.

After we drop runtime typechecks that were duplicating TS types this
function became a wrapper for 'assertValidSchema' so all implementations
that rely on it can now use 'assertValidSchema' directly.
@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Jun 13, 2022
@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 6ae5168
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/62a7afc0ebd28200086d324e
😎 Deploy Preview https://deploy-preview-3643--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov IvanGoncharov requested a review from yaacovCR June 13, 2022 21:45
@saihaj saihaj merged commit cfbc023 into graphql:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants