Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use exeContext strategically #3654

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

yaacovCR
Copy link
Contributor

  1. executeOperation can take only one parameter, operation is included within exeContext
  2. use spread syntax to retrieve properties from exeContext

@IvanGoncharov this is a small hopefully straightforward PR that can be merged (as two separate commits or as a squashed commit if you would prefer) if #3639 or #3644 are blocked.

@netlify
Copy link

netlify bot commented Jun 19, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 4e0ed36
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/62af7153fd11ee00091327f5
😎 Deploy Preview https://deploy-preview-3654--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR requested a review from a team June 19, 2022 19:12
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 19, 2022
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our current code base, this change makes a lot of sense.
Before this change, we passed the same data in two different ways.

That said I'm not in favor of one "mega argument" as we have in exeContext but that requires different separate refactoring.

@yaacovCR yaacovCR merged commit 467be3e into graphql:main Jun 21, 2022
@yaacovCR yaacovCR deleted the use-exe-context branch June 21, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants