polish: add tests for expectPromise and expectEqualPromisesOrValues
#3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
test-test-utils
branch
from
647f6d5 to
b474ab7
Compare
yaacovCR
changed the title
expectPromise and expectEqualPromisesOrValues
yaacovCR
added
the
PR: polish 💅
saihaj
approved these changes
Jun 22, 2022
adds tests for expectPromise and expectEqualPromisesOrValues
yaacovCR
force-pushed
the
test-test-utils
branch
from
99a75a3 to
cfefdc3
Compare
IvanGoncharov
approved these changes
Aug 6, 2022
There was a problem hiding this comment.
I left a minor comment about using ES6 syntax otherwise ready to be merged 👍
Note: In the long run, I don't think need to test both subscribe and createSourceEventStream. Currently, both functions are messy, but after the upcoming refactoring hopefully, we should have more modular code and don't need to check both. Similar to how we don't check the graphql function with all possible scenarios of the underlying function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds tests for
expectPromiseandexpectEqualPromisesOrValues#3620 introduced
expectEqualPromisesOrValueswith a TODO of moving to testUtils and testing.This PR accomplishes that, and also moves the related
expectPromisefunction, adding tests for that utility function as well.