incrementalDelivery: refactoring and streamlining #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
added
the
PR: polish 💅
robrichard
approved these changes
Sep 7, 2022
yaacovCR
force-pushed
the
refactor
branch
2 times, most recently
from
e68e6e8 to
58eaf9d
Compare
IvanGoncharov
previously requested changes
Sep 20, 2022
this function should catches errors and should never throw
if the asyncIterator's next method throws, no incremental payloads for the result are possible, similar to completing an asyncIterator without stream
|
|
yaacovCR
dismissed
IvanGoncharov’s stale review
commits separated out into separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit is meant to merged separately, i.e. "Rebase and Merge" rather than "Squash and Merge"
419fd37: moves
executeStreamFieldout of try block to better illustrate which code might throw2991c79: tiny refactor pushing the result of
handleFieldErrorrather than explicit null, following convention elsewhere71a8db4: rename
fieldPathtoitemPathwhen dealing with items, as elsewhere4df02ca: skip unnecessary filtering when asyncIterator's next method throws, aligning stream to non-stream