incrementalDelivery: use single execute function with directives as flags #3732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
Contributor
Author
|
My current preferred alternative to #3722 / #3727 / #3726 |
yaacovCR
added
the
PR: breaking change 💥
yaacovCR
force-pushed
the
single-execute
branch
from
4710984 to
7644420
Compare
Contributor
Author
|
Even if we don't take this solution in whole, we might want to extract out the removal of the unnecessary |
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Sep 13, 2022
extracted from graphql#3732
yaacovCR
force-pushed
the
single-execute
branch
from
7644420 to
9469a9c
Compare
Contributor
Author
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Sep 13, 2022
extracted from graphql#3732
yaacovCR
force-pushed
the
single-execute
branch
from
9469a9c to
d1dc85f
Compare
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Sep 20, 2022
extracted from graphql#3732
yaacovCR
force-pushed
the
single-execute
branch
2 times, most recently
from
06b8284 to
b4509cd
Compare
…ctives themselves The use of new experimental functionality triggered by directives does not need a separate runtime flag. The directives themselves are the flags and all operations passed to `execute` are assumed to be valid. Using TS conditional types, when new generic `TMaybeIncremental` parameter is set to true, return type of `execute` will be either an ExecutionResult or an IncrementalExecutionResultMap containing an `initialResult` and a generator of `subsequentResults`. While incremental delivery is designated as experimental, `TMaybeIncremental` will default to `false`. When incremental delivery is merged into the spec, it may be useful to adjust the default to `true`.
yaacovCR
force-pushed
the
single-execute
branch
from
b4509cd to
418b3a7
Compare
Contributor
Author
|
Closing in favor of #3722. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of new experimental functionality triggered by directives does not need a separate runtime flag. The directives themselves are the flags and all operations passed to
executeare assumed to be valid.Using TS conditional types, when new generic
TMaybeIncrementalparameter is set to true, return type ofexecutewill be either an ExecutionResult or an IncrementalExecutionResultMap containing aninitialResultand a generator ofsubsequentResults. While incremental delivery is designated as experimental,TMaybeIncrementalwill default tofalse. When incremental delivery is merged into the spec, it may be useful to adjust the default totrue.