Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github actions lint #3744

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix github actions lint #3744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/cmd-publish-pr-on-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ name: publish-pr-on-npm
on:
workflow_call:
inputs:
pullRequestJSON:
pull_request_json:
description: String that contain JSON payload for `pull_request` event.
required: true
type: string
secrets:
NPM_CANARY_PR_PUBLISH_TOKEN:
npm_canary_pr_publish_token:
description: NPM token to publish canary release.
required: true
jobs:
Expand All @@ -18,7 +18,7 @@ jobs:
uses: actions/checkout@v3
with:
persist-credentials: false
ref: ${{ fromJSON(inputs.pullRequestJSON).merge_commit_sha }}
ref: ${{ fromJSON(inputs.pull_request_json).merge_commit_sha }}

- name: Setup Node.js
uses: actions/setup-node@v3
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:

- name: Modify NPM package to be canary release
env:
PULL_REQUEST_JSON: ${{ inputs.pullRequestJSON }}
PULL_REQUEST_JSON: ${{ inputs.pull_request_json }}
uses: actions/github-script@v6
with:
script: |
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
- name: Publish NPM package
run: npm publish --ignore-scripts ./npmDist
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_CANARY_PR_PUBLISH_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.npm_canary_pr_publish_token }}

- name: Upload replyMessage
uses: actions/upload-artifact@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cmd-run-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: run-benchmark
on:
workflow_call:
inputs:
pullRequestJSON:
pull_request_json:
description: String that contain JSON payload for `pull_request` event.
required: true
type: string
Expand All @@ -15,11 +15,11 @@ jobs:
uses: actions/checkout@v3
with:
persist-credentials: false
ref: ${{ fromJSON(inputs.pullRequestJSON).merge_commit_sha }}
ref: ${{ fromJSON(inputs.pull_request_json).merge_commit_sha }}

- name: Deepen cloned repo
env:
BASE_SHA: ${{ fromJSON(inputs.pullRequestJSON).base.sha }}
BASE_SHA: ${{ fromJSON(inputs.pull_request_json).base.sha }}
run: 'git fetch --depth=1 origin "$BASE_SHA:refs/tags/BASE"'

- name: Setup Node.js
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/github-actions-bot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
runs-on: ubuntu-latest
outputs:
cmd: ${{ steps.parse-cmd.outputs.cmd }}
pullRequestJSON: ${{ steps.parse-cmd.outputs.pullRequestJSON }}
pull_request_json: ${{ steps.parse-cmd.outputs.pull_request_json }}
steps:
- uses: actions/github-script@v6
with:
Expand All @@ -76,23 +76,23 @@ jobs:

const { url } = context.payload.issue.pull_request;
const { data } = await github.request(url);
core.setOutput('pullRequestJSON', JSON.stringify(data, null, 2));
core.setOutput('pull_request_json', JSON.stringify(data, null, 2));

cmd-publish-pr-on-npm:
needs: [accept-cmd]
if: needs.accept-cmd.outputs.cmd == 'publish-pr-on-npm'
uses: ./.github/workflows/cmd-publish-pr-on-npm.yml
with:
pullRequestJSON: ${{ needs.accept-cmd.outputs.pullRequestJSON }}
pull_request_json: ${{ needs.accept-cmd.outputs.pull_request_json }}
secrets:
NPM_CANARY_PR_PUBLISH_TOKEN: ${{ secrets.NPM_CANARY_PR_PUBLISH_TOKEN }}
npm_canary_pr_publish_token: ${{ secrets.npm_canary_pr_publish_token }}

cmd-run-benchmark:
needs: [accept-cmd]
if: needs.accept-cmd.outputs.cmd == 'run-benchmark'
uses: ./.github/workflows/cmd-run-benchmark.yml
with:
pullRequestJSON: ${{ needs.accept-cmd.outputs.pullRequestJSON }}
pull_request_json: ${{ needs.accept-cmd.outputs.pull_request_json }}

respond-to-cmd:
needs:
Expand Down