Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-actions-bot): add additional permissions #3759

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

yaacovCR
Copy link
Contributor

sub-workflows cannot be called from parent workflow without sufficient permissions

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 73897c8
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/634e65c60d901a000ac63caa
😎 Deploy Preview https://deploy-preview-3759--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sub-workflows cannot be called from parent workflow without sufficient permissions
@yaacovCR
Copy link
Contributor Author

@IvanGoncharov I believe this change fixes the startup issue with the github-actions-bot.

I noticed that on this PR that itself changes the workflow, the unpatched workflow from main is being utilized. Is that the desired behavior?

See: https://github.com/graphql/graphql-js/actions/runs/3272036713/workflow

@yaacovCR yaacovCR requested a review from a team October 21, 2022 08:01
@IvanGoncharov
Copy link
Member

I noticed that on this PR that itself changes the workflow, the unpatched workflow from main is being utilized. Is that the desired behavior?

@yaacovCR Yes, it is done for security reasons since we allow bot to do restricted stuff (e.g. posting comments, publishing to npm, etc.)

@IvanGoncharov IvanGoncharov merged commit 16ab5cb into graphql:main Oct 21, 2022
@yaacovCR yaacovCR deleted the fix-github-actions branch October 23, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants