Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments in defer/stream validation rules #3781

Merged
merged 1 commit into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ describe('Validate: Defer/Stream directive on root field', () => {
expectValid(`
subscription {
subscriptionField {
...nestedFragment
...nestedFragment @defer
IvanGoncharov marked this conversation as resolved.
Show resolved Hide resolved
}
}
fragment nestedFragment on Message {
Expand Down
2 changes: 1 addition & 1 deletion src/validation/rules/DeferStreamDirectiveLabelRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import type { ValidationContext } from '../ValidationContext.js';

/**
* Stream directive on list field
* Defer and stream directive labels are unique
*
* A GraphQL document is only valid if defer and stream directives' label argument is static and unique.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import type { ValidationContext } from '../ValidationContext.js';

/**
* Stream directive on list field
* Defer and stream directives are used on valid root field
*
* A GraphQL document is only valid if defer directives are not used on root mutation or subscription types.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/validation/rules/StreamDirectiveOnListFieldRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { GraphQLStreamDirective } from '../../type/directives.js';
import type { ValidationContext } from '../ValidationContext.js';

/**
* Stream directive on list field
* Stream directives are used on list fields
*
* A GraphQL document is only valid if stream directives are used on list fields.
*/
Expand Down