Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose printDirective function to enable schema sharding #3822

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

tomgasson
Copy link

GraphQL schemas can end up quite large. Sharding the schema into multiple files is supported by clients like relay to allow you to split a large schema into multiple smaller files. This can reduce merge conflicts, and make things easier on the file system, git's operations and your IDE's syntax highlighting.

This PR exports the printDirective function, which will allow you to write your own custom implementation of printSchema for your own sharding mechanism. printType is already exported

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit b2ead32
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63bd5a925467640009e6d2a9
😎 Deploy Preview https://deploy-preview-3822--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tomgasson / name: Tom Gasson (b2ead32)

@github-actions
Copy link

Hi @tomgasson, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR added the PR: feature 🚀 requires increase of "minor" version number label Jan 10, 2023
@yaacovCR yaacovCR requested a review from a team January 10, 2023 13:47
@tomgasson
Copy link
Author

Any chance of this being merged in?

@IvanGoncharov IvanGoncharov merged commit d45e48b into graphql:main Apr 18, 2023
@IvanGoncharov
Copy link
Member

@tomgasson Merged, thanks for the ping!
If you want this change in v16, please, backport it to https://github.com/graphql/graphql-js/tree/16.x.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants