Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(incremental): do not initiate multiple streams at the same path #3830

Closed
wants to merge 8 commits into from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Jan 17, 2023

This builds upon the defer merging work in #3820.

The following operation:

query { 
  friendList @stream(initialCount: 2) {
    name
    id
  }
  ... @defer {
    friendList @stream(initialCount: 2) {
      name
      id
    }
  }
}

will now only result in a single stream.

Corresponding spec change is at: robrichard/graphql-spec#12

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 835fa56
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63e0fa99f60f670008eb8b30
😎 Deploy Preview https://deploy-preview-3830--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yaacovCR
Copy link
Contributor Author

closing this in favor of #3862

@yaacovCR yaacovCR closed this Mar 30, 2023
@yaacovCR yaacovCR deleted the do-not-multi-stream branch September 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant