-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ambiguity around when schema definition may be omitted #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
added
the
spec RFC
Implementation of a proposed change to the GraphQL specification
label
Feb 3, 2023
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
benjie
force-pushed
the
test-schema-definition-ambiguity
branch
from
February 3, 2023 09:57
97f1ea4
to
ac3cb10
Compare
cc @graphql/graphql-js-reviewers |
Going to close/reopen to see if Netlify retries 🤷♂️ |
Works nicely when ported to PHP: webonyx/graphql-php#1303. |
leebyron
force-pushed
the
test-schema-definition-ambiguity
branch
from
February 9, 2023 01:47
0ce831a
to
917f970
Compare
Moves the "no operation types" special case up to the caller. Renames the function to match the spec text
leebyron
force-pushed
the
test-schema-definition-ambiguity
branch
from
February 9, 2023 01:48
917f970
to
8a266f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: bug fix 🐞
requires increase of "patch" version number
spec RFC
Implementation of a proposed change to the GraphQL specification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the tests and fixes necessary for Spec RFC #987.
The main changes
This PR is made of three main commits:
Query
,Mutation
andVirus
types, but only supportsquery
operations (via theQuery
type) and does not supportmutation
operations.Unnecessary test?
The fourth commit addresses the following failing test that I didn't know what to do about:
graphql-js/src/utilities/__tests__/buildClientSchema-test.ts
Lines 65 to 81 in 76e47fc
I don't understand the reasoning behind this test. It seems to me that the schema output from this should instead be:
since the schema has no operation types (but uses the default names); however this is unparseable (because
{}
is unparseable). Perhaps @IvanGoncharov or @leebyron can shed some light on the reasoning behind this test? I've worked around it by special casing it, but I'd prefer to remove the special case code and also remove the test case.