Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fourfold nested lists in introspection #3948

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

gschulze
Copy link
Contributor

This PR adds support for introspecting four-fold nested lists, which in turn allows proper representation of GeoJSON multipolygons (https://datatracker.ietf.org/doc/html/rfc7946#section-3.1.7).

Closes #2643

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gschulze / name: Gunnar Schulze (28e4ea5)

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 28e4ea5
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64d54821990f160008beb836
😎 Deploy Preview https://deploy-preview-3948--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gschulze gschulze force-pushed the support-fourfold-nested-lists branch from 78834ca to 28e4ea5 Compare August 10, 2023 20:26
@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Aug 11, 2023
@IvanGoncharov
Copy link
Member

@gschulze Thank you for explaining why you need this.
Definitely worth merging, if you need it in the v16 line please submit a PR to the 16.x.x branch.

P.S. We definitely need to add something to the spec to properly solve this problem 🤔

@IvanGoncharov IvanGoncharov merged commit 826ae7f into graphql:main Aug 11, 2023
19 checks passed
@gschulze
Copy link
Contributor Author

@IvanGoncharov thanks for merging! I made a PR to the 16.x.x branch as you proposed: #3950

I think the underlying problem more or less boils down to always having to specify every field at every level. Maybe having wildcard support like proposed in graphql/graphql-spec#127 would help here. That also would make handling of polymorphic types much easier on the client side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorated type deeper than introspection query. 4d array
2 participants