Fix test assertions for validation test when using custom TypeInfo #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test should had broke for changes in graphql#355 which improved validation messages with suggestions. - But `expect().to.deep.equal()` checks for the right number of errors but does not check for equality of error messages.
|
Thanks for your help and careful reading! |
sogko
added a commit
to sogko/graphql-js
that referenced
this pull request
Jan 27, 2017
Merge commit '826cba3b76e87dbd25a01db5150f89624adaab32' into sogko/master * commit '826cba3b76e87dbd25a01db5150f89624adaab32': 0.6.1 Fix tests for node v0.10, widen test matrix Fix test assertions for validation test when using custom TypeInfo (graphql#395) Removes depencency on babel-runtime. Upgrade to Flow v0.28. More specific return types from methods in Schema Only type Scalar config rather than Scalar type, improve schema builder types Introduce formal definition of "Thunk" to aid in fixing more issues uncovered by Flow v0.28 Additional flow issues corrected in anticipation of Flow v0.28 Fix some flow issues in anticipation of Flow v0.28 export type InputObjectConfigFieldMapThunk (graphql#411) Variable naming follow-up to path generation Errors thrown from resolvers have the execution path (graphql#396) Update all dependencies, include flow-specific lint handling Revert "Update babel-cli and flow-bin package references" (graphql#403) move babel config to the babelrc (graphql#399) Update babel-cli and flow-bin package references (graphql#388) Fix typo (graphql#387)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expect().to.deep.equal()checks for the right number of errors but does not check for equality of error messages.Notes:
npm run checkcomplained that the error messages were too long; broke each error into 2 lines.PS: Can someone with travis access re-run the build? It failed for only one of the environment
nodejs 4, seems likeflowdidn't get installed properly (ENOENTerror)