Skip to content

Introduce "recommended" validation rules #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjie merged 37 commits into from
Jun 21, 2024
Merged

Introduce "recommended" validation rules #4118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
16850e1
introduce rule
enisdenjo Apr 11, 2024
5fe9959
also __type
enisdenjo Apr 15, 2024
f2a56e7
shorter error
enisdenjo Apr 15, 2024
3b90c85
fragment spread wont have more selections
enisdenjo Apr 15, 2024
d388992
MaxIntrospectionDepthRule
enisdenjo Apr 15, 2024
8f45b75
count or reach
enisdenjo Apr 15, 2024
48cb905
ultra shorter
enisdenjo Apr 15, 2024
290091a
unused arg
enisdenjo Apr 15, 2024
860e1f6
validationcontext
enisdenjo Apr 15, 2024
1d5f90a
max fields 4 appearances
enisdenjo Apr 15, 2024
c7b84f1
failing test
enisdenjo Apr 15, 2024
b09145b
back to counter
enisdenjo Apr 15, 2024
b63e328
max introspection nodes
enisdenjo Apr 15, 2024
363257d
typo
enisdenjo Apr 15, 2024
38f7638
simpler
enisdenjo Apr 15, 2024
8ede99f
introspection depth
enisdenjo Apr 22, 2024
d9e48f6
varying parents and no copy-paste query
enisdenjo Apr 22, 2024
ae49605
same same
enisdenjo Apr 22, 2024
3205004
no arr
enisdenjo Apr 22, 2024
0c36d59
inline fragments
enisdenjo Apr 22, 2024
6892b20
disallow fields, interfaces, possibleTypes, inputFields
enisdenjo Apr 22, 2024
0398d7b
start from OperationDefinition and pass in node
enisdenjo Apr 22, 2024
62b5d73
use kind.field
enisdenjo Apr 22, 2024
a61085b
better comment
enisdenjo Apr 22, 2024
537eda5
opts out if fragment is missing
enisdenjo Apr 23, 2024
a2a5060
use fields and inline fragment on schema
enisdenjo Apr 29, 2024
4ba281e
we're counting lists
enisdenjo Apr 29, 2024
1fa81c0
less clever
enisdenjo May 20, 2024
572b51f
dont break, just dont visit further
enisdenjo May 20, 2024
95fcced
3 input fields
enisdenjo May 20, 2024
77767b8
doesn't infinitely recurse on fragment cycle
enisdenjo Jun 3, 2024
7f16076
reorder
enisdenjo Jun 3, 2024
d1113cc
=== true
enisdenjo Jun 3, 2024
b15fbcd
leave todo
enisdenjo Jun 3, 2024
0eb5b88
comment
enisdenjo Jun 19, 2024
bb122de
Move recommended rules to their own list
benjie Jun 21, 2024
73e2166
Merge branch 'main' into maxintfields
benjie Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ export {
ValidationContext,
// All validation rules in the GraphQL Specification.
specifiedRules,
recommendedRules,
// Individual validation rules.
ExecutableDefinitionsRule,
FieldsOnCorrectTypeRule,
Expand Down Expand Up @@ -382,6 +383,7 @@ export {
ValuesOfCorrectTypeRule,
VariablesAreInputTypesRule,
VariablesInAllowedPositionRule,
MaxIntrospectionDepthRule,
// SDL-specific validation rules
LoneSchemaDefinitionRule,
UniqueOperationTypesRule,
Expand Down
Loading