-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flexibility around the waiting period for merging PRs #4172
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this makes sense much more sense and we can iterate fast. Let's wait for @JoviDeCroock or someone else from the team (unless it was discussed in last WG) to merge
Not yet discussed at a WG meeting, and I agree that, for example, according to the rubric suggested in this PR, changing the merging guidelines would be considered itself a large change and be appropriate for delaying until after a WG discussion. Although I will be in transit at the next one so will not be able to join. :) |
I continue to think that very specific rules slow down velocity too much, and that the guiding principle should be that all changes should be made by consensus, with the idea that no change is set in stone.
as a blanket rule is not helpful
No description provided.