Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexibility around the waiting period for merging PRs #4172

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

yaacovCR
Copy link
Contributor

No description provided.

@yaacovCR yaacovCR requested a review from a team as a code owner August 19, 2024 05:01
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit e9929ab
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66daf4f60bb5aa00090fddfd
😎 Deploy Preview https://deploy-preview-4172--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this makes sense much more sense and we can iterate fast. Let's wait for @JoviDeCroock or someone else from the team (unless it was discussed in last WG) to merge

@yaacovCR
Copy link
Contributor Author

Not yet discussed at a WG meeting, and I agree that, for example, according to the rubric suggested in this PR, changing the merging guidelines would be considered itself a large change and be appropriate for delaying until after a WG discussion. Although I will be in transit at the next one so will not be able to join. :)

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
I continue to think that very specific rules slow down velocity too much, and that the guiding principle should be that all changes should be made by consensus, with the idea that no change is set in stone.
as a blanket rule is not helpful
@yaacovCR yaacovCR merged commit be16adf into graphql:main Sep 6, 2024
20 checks passed
@yaacovCR yaacovCR deleted the flex branch September 6, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants