-
Notifications
You must be signed in to change notification settings - Fork 2k
Add sourcemaps to our published bundles #4231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
Do we also need to publish the TS source for this to be useful? |
No, sourcemaps should be able to fully standalone do these translations. There is a sourcesContent key in the sourcemap that basically encodes all that information, I should probably check whether TS correctly implements that though. EDIT: yes that works |
449a065
to
207f4dc
Compare
207f4dc
to
9fd1c73
Compare
from: graphql/graphql-js#4231 Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
* add source map support * add support to release from: graphql/graphql-js#4231 Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> * add changeset --------- Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Fixes #2470