Add sourcemaps to our published bundles #4231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
added
the
PR: polish 💅
|
Do we also need to publish the TS source for this to be useful? |
|
No, sourcemaps should be able to fully standalone do these translations. There is a sourcesContent key in the sourcemap that basically encodes all that information, I should probably check whether TS correctly implements that though. EDIT: yes that works |
JoviDeCroock
force-pushed
the
enable-sourcemaps
branch
from
449a065 to
207f4dc
Compare
JoviDeCroock
force-pushed
the
enable-sourcemaps
branch
from
207f4dc to
9fd1c73
Compare
yaacovCR
approved these changes
Oct 14, 2024
yaacovCR
added a commit
to yaacovCR/transform
that referenced
this pull request
Mar 9, 2025
from: graphql/graphql-js#4231 Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
yaacovCR
added a commit
to yaacovCR/transform
that referenced
this pull request
Mar 9, 2025
* add source map support * add support to release from: graphql/graphql-js#4231 Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> * add changeset --------- Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2470