further refine incremental result types #4323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
continue work with graphql#4313
use TIncrementalItem instead of TItems to constrain to ReadonlyArray of TIncrementalItem
yaacovCR
force-pushed
the
incremental-type-fix
branch
from
c72159a to
22f8a66
Compare
|
This PR fixes the types for Subsequent Execution Results by splitting up the generics between the deferred result data and the streamed item type, so that the constituent types can now be properly typed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue work with #4313
Fixes the types for Subsequent Execution Results. Currently, the generic argument for subsequent results is passed to deferred and streamed results. By providing two different generic arguments, we can get properly types individual members of the incremental array.