Add object level default resolve function #734
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This looks pretty awesome! |
southpolesteve
changed the title
|
I've updated this PR with documentation edits |
| @@ -139,4 +140,21 @@ describe('Execute: resolve function', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it.only('uses object provided resolve function', async () => { | |||
Add docs Remove .only
southpolesteve
force-pushed
the
default-object-level-resolver
branch
from
4ec8a3f to
da7f5e2
Compare
|
Unfortunately I will close this PR after discussion in the related issue. There is too much confusion around how these functions would be called - other requests for similar features have looked for very different semantics (others often want a resolver for the returnType instead of parentType). That said, I have no qualms with this pattern, however I would prefer the use of composition to provide this behavior - a change to the core GraphQLObject API is not necessary to enable this! |
Adds the ability to specify a resolve function for an entire object type. Closes #733