Sort fields before printing to get a more stable diff #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wincent
reviewed
May 30, 2017
| @@ -585,7 +585,7 @@ describe('Subscribe', () => { | |||
| invalidEmailSchema, | |||
| ast | |||
| ); | |||
| }).to.throw('Subscription must return AsyncIterable. Received: test'); | |||
| }).to.throw('Subscription must return Async Iterable. Received: test'); | |||
|
Thnaks @tberman. |
|
Unfortunately this PR broke how this utility is used for printing schema in tests and tools - the sorted behavior changed which fields appear first which some tools rely on. I'm reverting this change, I suggest if stable diffs are required via field sorting, that fields are sorted while still in the schema rather than during printing of the schema. Otherwise the defined order of fields is stable and should be kept stable by this function as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the fields of an object similar to how types are being sorted.