Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Incompatible graphql-language-service-utils #239

Closed
brosander opened this issue Jun 4, 2018 · 5 comments
Closed

Incompatible graphql-language-service-utils #239

brosander opened this issue Jun 4, 2018 · 5 comments

Comments

@brosander
Copy link

In npm, the current version of graphql-language-service-utils is 1.2.1 which seems to have issues when resolved transitively by the other older components.

Forcing graphql-language-service-utils to 1.2.0 resolves our build issue.

@JWimsingues
Copy link

JWimsingues commented Jun 4, 2018

Same experience on our side...
Getting this error message

Module not found: Error: Can't resolve 'graphql/validation/rules/ExecutableDefinitions' in '../node_modules/graphql-language-service-utils/dist'

solved by reverting to the last release which worked on our side (graphql-language-service-utils-1.0.18.tgz")

@jlai
Copy link

jlai commented Jun 8, 2018

ExecutableDefinitions.js doesn't exist until graphql 1.12.0, but https://github.com/graphql/graphql-language-service/blob/master/packages/utils/package.json allows 0.10.0 and up

@lostplan
Copy link
Collaborator

So, as far as I can tell, either we need to revert 068c57f or utils needs to drop peerdep support for graphql v0.10 and v0.11. Does that sound right?

Pinging authors @divyenduz @asiandrummer – do you have any thoughts on this? Is there any precedent for when/how to drop support for older peerdeps?

@tgvashworth
Copy link

Hey folks — I ran into this again today. Any progress?

@lostplan
Copy link
Collaborator

lostplan commented Jul 9, 2018

v0.12 was released back in December so let's drop support for v0.11 (and below). This will require a major version bump for graphql-language-service (edit: I will do this)

Could someone make a PR?

lostplan added a commit to lostplan/graphql-language-service that referenced this issue Sep 10, 2018
Drop support for graphql v0.10 and v0.11 as these versions do not contain
`ExecutableDefinitions` (required by
packages/utils/src/validateWithCustomRules.js)

N.b. this will require a major version bump at the next release.

Fixes graphql#239
lostplan added a commit that referenced this issue Sep 18, 2018
…256)

Drop support for graphql v0.10 and v0.11 as these versions do not contain
`ExecutableDefinitions` (required by
packages/utils/src/validateWithCustomRules.js)

N.b. this will require a major version bump at the next release.

Fixes #239
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants