renderPlaygroundPage - cdnUrl config option #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the cdn url to be passed in to renderPlaygroundPage as an option. This is to support graphql-playground being used offline by tools such as Apollo Server. See apollographql/apollo-server#1421
|
|
huv1k
reviewed
Sep 24, 2018
huv1k
approved these changes
Sep 24, 2018
9 tasks
|
Related, I think if I'll add this patch to this PR |
If version is not passed then don't append @ to the cdn url. This is to aid serving from localhost from a folder with no given version number. See graphql#845
|
@HuVik thanks, I've made a minor change since your approval, to accompany a working example I'll put on GitHub shortly |
|
working example here, though some npm link magic needed to get it to work :-) |
|
Thanks for your first contribution! It will be in next release 🚀 |
cgxxv
pushed a commit
to cgxxv/graphql-playground
that referenced
this pull request
Mar 25, 2022
* renderPlaygroundPage - cdnUrl config option Allow the cdn url to be passed in to renderPlaygroundPage as an option. This is to support graphql-playground being used offline by tools such as Apollo Server. See apollographql/apollo-server#1421 * don't insert @ in cdn url if no version given If version is not passed then don't append @ to the cdn url. This is to aid serving from localhost from a folder with no given version number. See graphql#845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the cdn url to be passed in to renderPlaygroundPage as an option. This is to support graphql-playground being used offline by tools such as Apollo Server. See apollographql/apollo-server#1421