Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Update express mw to latest graphql-playground-html #984

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix(deps): Update express mw to latest graphql-playground-html #984

merged 1 commit into from
Apr 3, 2020

Conversation

mmmeff
Copy link
Contributor

@mmmeff mmmeff commented Feb 28, 2019

graphql-playground-middleware-express package.json should now point to the latest version of html.

My team's licensing automation is still failing because the 1.6.13 fixes aren't being picked up by this pinned version

graphql-playground-middleware-express' package.json should now point to the latest version
@mmmeff
Copy link
Contributor Author

mmmeff commented Mar 5, 2019

@HuVik The last CR I cut didn't quite fix this issue sadly - I think there's an issue with the release scripts in the monorepo that forgot to update this dependency version.

Any chance we can get this one fast tracked well? We're still blocked by this on my team :(

@smashercosmo
Copy link

Any updates on this? We also suffer from license linting failures because of this.

@acao
Copy link
Member

acao commented Apr 3, 2020

gonna make a security update PR today! this PR would need a yarn.lock bump as well.

@acao
Copy link
Member

acao commented Apr 3, 2020

for a full security update, this is going to require a few changes, and it's not proving easy to do without deleting the lockfile and completely regenerating it, which has already introduced its own set of problems. possibly i will need to manually change the lockfile from the master version, remove these last 5 security issues with hapi manually, and make sure it re-generates as such. it also appears this repo also doesn't have tests which has me worried

Copy link
Member

@acao acao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mmmeff , lets see if dependabot generates a lockfile update for us. i'm not familiar with having 7 yarn lock files in one monorepo! yikes, haha

@acao acao changed the title Updated package.json package versions fix(deps): Update express mw to latest graphql-playground-html Apr 3, 2020
@acao acao merged commit 0bc65e8 into graphql:master Apr 3, 2020
@acao acao mentioned this pull request Apr 3, 2020
23 tasks
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
…ql#984)

`graphql-playground-middleware-express` `package.json` should now point to the latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants