Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Clarify meta-fields in introspection #844

Merged
merged 5 commits into from
Apr 9, 2021

Conversation

leebyron
Copy link
Collaborator

@leebyron leebyron commented Apr 8, 2021

Derived from #777

Renames "field" to "meta-field" consistently. Adds "with the single exception of the subscription root
operation type". Clarifies some language.

Derived from #777

Renames "field" to "meta-field" consistently. Adds "with the single exception of the subscription root
operation type". Clarifies some language.
@leebyron leebyron added the ✏️ Editorial PR is non-normative or does not influence implementation label Apr 8, 2021
@leebyron leebyron added this to the May2021 milestone Apr 8, 2021
@leebyron leebyron requested review from benjie and a team April 8, 2021 04:21
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this improvement to consistency 👍 I've tried to edit the text to make it easier to read and more precise, hopefully this helps 🤞

spec/Section 4 -- Introspection.md Outdated Show resolved Hide resolved
spec/Section 4 -- Introspection.md Outdated Show resolved Hide resolved
spec/Section 4 -- Introspection.md Outdated Show resolved Hide resolved
leebyron and others added 3 commits April 8, 2021 21:57
Co-authored-by: Benjie Gillam <benjie@jemjie.com>
Co-authored-by: Benjie Gillam <benjie@jemjie.com>
Co-authored-by: Benjie Gillam <benjie@jemjie.com>
@leebyron
Copy link
Collaborator Author

leebyron commented Apr 9, 2021

Great suggestions! Applied them all

@leebyron leebyron merged commit f474e66 into main Apr 9, 2021
@leebyron leebyron deleted the editorial-introspection branch April 9, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants