Skip to content

Move punctuation outside quotation marks #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

spawnia
Copy link
Member

@spawnia spawnia commented Jun 14, 2022

As discussed in graphql/graphql-over-http#175 (comment) - @benjie

Every variant of the MIT license does it this way, see https://fedoraproject.org/wiki/Licensing:MIT for reference.

As discussed in graphql/graphql-over-http#175 (comment) - @benjie 

Every variant of the MIT license does it this way, see https://fedoraproject.org/wiki/Licensing:MIT for reference.
@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 4d760bc
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/62a84d484a69360008ba6169
😎 Deploy Preview https://deploy-preview-962--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though the grammar is "wrong," since the standard license is written in this way I think we should use the standard license formatting. 😞

@spawnia
Copy link
Member Author

spawnia commented Jun 14, 2022

Let this be the change we want to see in the grammar rules, they can be what we make it ✨

@leebyron
Copy link
Collaborator

🤷

@leebyron leebyron merged commit bb95060 into graphql:main Jun 16, 2022
@leebyron leebyron added the ✏️ Editorial PR is non-normative or does not influence implementation label Jun 16, 2022
@spawnia spawnia deleted the patch-4 branch June 16, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants