Fix search for gatsby site #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly: The previous version of the site would load the page from scratch every time, so calling an external lib at the footer was a reasonable call. Gatsby on the other hand, won't do a full reliable re-render of a page and so when you're interacting with
scripttags etc. There needs to be a bit more dancing to hook stuff up.This technique is almost C&P'd from the TypeScript website. A different potential fix is to move to the v3 docsearch implementation - microsoft/TypeScript-Website#928, which is done entirely within the bundler context and algolia have done a good job making it work in theses SPA-y sites.
For now this is enough to make it all work right