Skip to content
This repository has been archived by the owner on Jul 31, 2022. It is now read-only.

feat: provide 'Execute Query' for /* GraphQL */ templates #277

Merged
merged 1 commit into from
Dec 10, 2021
Merged

feat: provide 'Execute Query' for /* GraphQL */ templates #277

merged 1 commit into from
Dec 10, 2021

Conversation

AumyF
Copy link
Contributor

@AumyF AumyF commented Jan 27, 2021

It partially fixes #232.
(Completions still don't work; we may need to fix graphql-language-service-server.)

image

@acao
Copy link
Member

acao commented Nov 26, 2021

@AumyF awesome! yes correct, I can show you where that lives in the language server, findGraphQLTags.

@acao
Copy link
Member

acao commented Dec 1, 2021

https://github.com/graphql/graphiql/blob/fe5bb0dca326ee307bb6a618536819c0b505f7c9/packages/graphql-language-service-server/src/findGraphQLTags.ts#L71 here is where we specify the template tags - i.e. gql`` , graphql``, gql(), and graphql().

in order to pick up on a comment such as this one or #graphql comment declaration, we will need to add new babel parser visitors

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2021

🦋 Changeset detected

Latest commit: c68375a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 10, 2021

CLA Not Signed

@acao
Copy link
Member

acao commented Dec 10, 2021

I'm terribly sorry @AumyF , when rebasing your commit to handle upstream conflicts and add changeset I somehow broke the authorship by accident, and now the CLA bot isn't happy ://. i tried doing `git commit --amend --author="Aumy "

@acao acao merged commit 6017872 into graphql:master Dec 10, 2021
@github-actions github-actions bot mentioned this pull request Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support /* GraphQL */ template string comment tags
2 participants