Skip to content
This repository has been archived by the owner on Jul 31, 2022. It is now read-only.

Enable in vue files #307

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Enable in vue files #307

merged 1 commit into from
Dec 6, 2021

Conversation

tobiasdiez
Copy link
Contributor

This enables the extension in vue files as well.

Doesn't quite work yet and depends on a proper implementation of the server backend: graphql/graphiql#1678

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2021

CLA Signed

The committers are authorized under a signed CLA.

@acao
Copy link
Member

acao commented Nov 26, 2021

@tobiasdiez can you sign the CLI? this would be awesome to contribute! I appreciate it!

@tobiasdiez
Copy link
Contributor Author

I've already signed the CLA for the graphql specs orgs (graphql/graphql-spec#881). But for some reason this is not picked up here, and signing again also doesn't work (afterwards I'm redirected to the above PR).

@acao
Copy link
Member

acao commented Dec 1, 2021

@brianwarner do you know why this bug with the CLA bot is happening?

@tobiasdiez until then, I can create a new PR and give you co-author credit :) would love to get this out in the next release along with language server improvements!

@tobiasdiez
Copy link
Contributor Author

Sure, feel free to (re)use my changes as you see fit!

@brianwarner
Copy link
Contributor

Hmm, I'm not sure, I see the signature in the system. However, it may be that EasyCLA needs to be manually run. One sec and I'll drop in the magic comment that does it.

@brianwarner
Copy link
Contributor

/easycla

@brianwarner
Copy link
Contributor

That worked!

@acao
Copy link
Member

acao commented Dec 6, 2021

@tobiasdiez ready to merge, thank you for this! I will keep you posted as we find ways to support language features in vue files

@acao acao merged commit f022958 into graphql:master Dec 6, 2021
@tobiasdiez tobiasdiez deleted the vue branch December 6, 2021 15:03
@zigomir
Copy link

zigomir commented Dec 8, 2021

Causes #380

@acao acao mentioned this pull request Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants