Skip to content
This repository has been archived by the owner on Jul 31, 2022. It is now read-only.

Show the output channel when clicking on graphql status bar #436

Merged
merged 3 commits into from
Feb 20, 2022

Conversation

orta
Copy link
Member

@orta orta commented Feb 15, 2022

As knowing whether you are in debug or not isn't too useful from a users perspective

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2022

🦋 Changeset detected

Latest commit: 5554f54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao
Copy link
Member

acao commented Feb 16, 2022

Great idea! Not sure why the changeset isn’t picking up, I’ll look into it later

@acao
Copy link
Member

acao commented Feb 18, 2022

@orta if you bump graphql-language-service-server when you rebase this, then you'll have the LSP improvements as well! or a seperate PR for that, your choice

@orta
Copy link
Member Author

orta commented Feb 19, 2022

Makes sense, bumped the version!

@acao
Copy link
Member

acao commented Feb 19, 2022

I think I introduced conflicts via merging a dependabot PR, oof

@orta
Copy link
Member Author

orta commented Feb 19, 2022

( It says it has no conflicts to me )

@acao
Copy link
Member

acao commented Feb 19, 2022

maybe it’s a cacheing issue? Or a github bug? I see this on both my phone and desktop… hmm!!

0C73CC2B-FCC5-4771-9148-560FC15D3F4E

@orta
Copy link
Member Author

orta commented Feb 20, 2022

image

hah

@orta
Copy link
Member Author

orta commented Feb 20, 2022

maybe that's merge vs rebase., will try do it manually anyway

@acao
Copy link
Member

acao commented Feb 20, 2022

thank you! that was so weird, still not sure what happened haha

@acao acao changed the title Adds support for making clicking on the graphql status item show the output channel Show the output channel when clicking on graphql status bar Feb 20, 2022
@acao acao merged commit dc771c7 into graphql:master Feb 20, 2022
@acao
Copy link
Member

acao commented Feb 20, 2022

@orta I don't know why but the Version Packages PR isn't being created by changsets :((

@orta
Copy link
Member Author

orta commented Feb 20, 2022

heh, sounds to me like a lot of annoying automation on this repo. At least it won't be for long

@acao
Copy link
Member

acao commented Feb 20, 2022

Yup! Working on that PR now

we should make a nice graphic for the monorepo readme to explain what is what, and how vscode-graphql and graphiql are sharing the internal LS dependencies. The one i have now seems to scare people! Haha

@acao
Copy link
Member

acao commented Feb 20, 2022

I originally added changesets here because it used to deploy on every merge which was a huge problem. Semantic release wouldve been better in retrospect, especially with the auto-comment-with-release-version-and-close tickets feature. This would save so much time with releases

Also tried setting up prerelease, but at least when they introduced it and the vscode PM reached out to me to use it, it didn’t support semver prerelase notation? So vscode prerelease at least a few months ago didnt support prerelease version notation like rc or beta

@github-actions github-actions bot mentioned this pull request Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants