This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Fix debug builds #172
Merged
Fix debug builds #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inickles-grapl
approved these changes
Jul 21, 2020
| @@ -131,6 +131,10 @@ RUN if test "${release_target}" = "release"; then \ | |||
| cargo clean; \ | |||
| cargo build --target=x86_64-unknown-linux-musl --release; \ | |||
| fi | |||
| RUN if test "${release_target}" = "debug"; then \ | |||
| cargo clean; \ | |||
| cargo build --target=x86_64-unknown-linux-musl; \ | |||
There was a problem hiding this comment.
Doesn't the cargo test call on L128 do this already?
There was a problem hiding this comment.
oh, it only builds node-identifier and node-identifier-retry-handler, because those are the only services with tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously skipping debug builds and producing empty binaries.