Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diff command. #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding diff command. #2

wants to merge 2 commits into from

Conversation

grasmash
Copy link
Owner

@grasmash grasmash commented Jan 9, 2017

I have some reservations about merging this:

  1. This command (as well as the merge and split commands) is significantly more complex than the existing commands.
  2. This command feels a bit more niche and less universally useful.
  3. The command doesn't seem to work entirely as intended. Comparing https://github.com/grasmash/yaml-cli/blob/diff-command/tests/resources/good.yml against https://github.com/grasmash/yaml-cli/blob/diff-command/tests/resources/good_also.yml does not register the different in inline-array.

@jmolivas @enzolutions

  • Would you be open to leaving diff, split, and merge in Drupal console and using this library (yaml-cli) only for the existing commands?
  • Are the diff, split, and merge commands used internally in Drupal console, or are they used by the community as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant