Check for event type, not order status

This prevents mispayments (after an order is complete) from modifying one's balance.
gratipay · Apr 13, 2015 · fefe657 · fefe657
1 parent d134d4d
commit fefe657
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tests/py/test_callbacks.py b/tests/py/test_callbacks.py
@@ -94,7 +94,9 @@ def test_coinbase_success_callback(self, re):
  body = json.dumps({
  "order": {
  "id": "10N9LK1Q",
- "status": "completed",
+ "event": {
+ "type": "completed"
+ },
  "total_native": {
  "cents": 100,
  "currency_iso": "USD"

diff --git a/www/callbacks/coinbase.spt b/www/callbacks/coinbase.spt
@@ -32,7 +32,7 @@ if order:
  if not isinstance(route, ExchangeRoute):
  route = ExchangeRoute.insert(participant, 'coinbase-payin', order['id'])
 
- status = order['status']
+ status = order['event']['type']
 
  # We're ignoring mispayments/expired orders here.
  if status == 'completed':