Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

change nomenclature from participant_id to username #287

Closed
chadwhitacre opened this issue Sep 13, 2012 · 3 comments
Closed

change nomenclature from participant_id to username #287

chadwhitacre opened this issue Sep 13, 2012 · 3 comments

Comments

@chadwhitacre
Copy link
Contributor

This is a db schema change. I constantly catch myself calling it username but I want to stay consistent.
@chadwhitacre
Copy link
Contributor Author

Surfaced while working on #80.

@chadwhitacre chadwhitacre mentioned this issue Feb 24, 2013
Closed
chadwhitacre added a commit that referenced this issue Apr 4, 2013
@chadwhitacre
Start branch.sql to fix username/id; #287, #680
553e656 
This breaks pretty much everything, as promised:

    https://twitter.com/whit537/status/319426649479344128
    https://twitter.com/whit537/status/319493424917143552

:)
chadwhitacre added a commit that referenced this issue Apr 5, 2013
@chadwhitacre
Get homepage working with username; #287, #680
963be5d
chadwhitacre added a commit that referenced this issue Apr 5, 2013
@chadwhitacre
Rename %participant_id dir to %username; #287
e9f021d
chadwhitacre added a commit that referenced this issue Apr 5, 2013
@chadwhitacre
Big changeover from id to username; #287
28cb48c 
I sort of did this one with the blast shield down. I haven't even run
the tests yet. The sorts of things I changed:

 - SQL {elsewhere,exchanges}.participant_id => .participant
 - SQL participants.id => .username
 - ORM {user,participant,self}.id => .username
chadwhitacre added a commit that referenced this issue Apr 5, 2013
@chadwhitacre
Started working through test failures; #287
7894d23
@chadwhitacre
Copy link
Contributor Author

Does SQLAlchemy special case id attributes or something? I have a hunch we're getting caught in some magic because I'm trying to use username as the primary key and id as a unique serial though not the primary key.

chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Fix some tests re: participant model; #287
3982930
chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Test suite is passing! #287
9474ae8
chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Add at least one test for id; #287
dc2020e
@chadwhitacre
Copy link
Contributor Author

No magic. I needed to update the Tip model.

chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Fix a regression in the history page; #287
194f4bf
chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Fix regressions in Delpan report; #287
4a844d4
chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Fix regressions in stats; #287
f02322c
chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Fix regression in on/confirm.html; #287
58ce8fb
chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Comment out mixpanel code; #686
a43d206 
I accidentally added mixpanel code on the username branch (see #287 and
 #680) by creating that branch while on the mixpanel branch. Now the
username/id stuff is deployed and our app is looking for MIXPANEL_TOKEN,
but I'm not ready to send stuff to Mixpanel yet. This simply comments
out the mixpanel calls I had added so far.
chadwhitacre added a commit that referenced this issue Apr 7, 2013
@chadwhitacre
Append branch.sql to schema.sql and prune; #287
899365f
chadwhitacre added a commit that referenced this issue Apr 8, 2013
@chadwhitacre
Fix regression in fraud review dashboard; #287
fd673c9
@chadwhitacre chadwhitacre mentioned this issue Apr 11, 2013
Closed
33 tasks
chadwhitacre added a commit that referenced this issue Apr 11, 2013
@chadwhitacre
Fix two regressions that snuck in on #287
333ddb4
@chadwhitacre chadwhitacre mentioned this issue Apr 11, 2013
Closed
chadwhitacre added a commit that referenced this issue Apr 11, 2013
@chadwhitacre
Fix regression in payday script with #287
34e23ab
chadwhitacre added a commit that referenced this issue Apr 11, 2013
@chadwhitacre
Fix regression in billing with #287
2f88d9f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chadwhitacre