add google authentication

[chadwhitacre]

Should be able to authenticate with a Google+ account. If already authenticated, should associated Google+ profile with existing Gittip participant account.

This is near and dear to my heart because Guido uses Google+, and doesn't use Github or Facebook or Twitter.

[joonas]

I decided to take a look back in time to see what we've got open, and came across this.

So given the current situation, how difficult do you think implementing this would be? I assume this should be implemented with Google's OAuth2 for Login?

[lyndsysimon]

Profile routing would be an issue. Both Twitter and Github have usernames that are both URL-friendly and human-friendly; Google doesn't.

/on/google/104460120585566250078/ doesn't quite have the ring to it that /on/github/lyndsysimon/ has.

[chadwhitacre]

@joonas I would expect this to mean some refactoring of gittip.elsewhere, but hopefully not as much as when we added Twitter support. If you'd like to take this on, go for it (assign it to yourself per usual).

@lyndsysimon Yeah, I think we have to work with what Google gives us, unfortunately.

[chadwhitacre]

@joonas I would approach this by copy/pasting /on/twitter to /on/google and going from there.

[lyndsysimon]

I've begun working on this issue at PyCon - you can see my progress on my fork.

At this point, I've got it hooked up so that the /on/google// pages display properly. Next up is OAuth support.

[chadwhitacre]

Awesome, thanks @lyndsysimon! :D

[lyndsysimon]

I'm taking a little bit of a break on this, but have made some significant progress. I've abstracted out the "elsewhere providers" concept into a single class, which will allow us to add additional providers without modifying the file structure.

To-dos at this point include:

• Implementing actions other than 'opt-in' on the OAuth response handler
• Finalizing architecture between gittip.elsewhere.ServiceElsewhere and AccountElsewhere. That could be by merging the two classes, or all account-level methods could be moved from Service to Account. I've not decided yet.
• Make sure to add a flag for gittip_login_provider, False by default.

My fork, linked above, has my most recent code and will be updated at the end of each hack session I work on this.

[chadwhitacre]

Thanks, Lyndsy! This is an important piece of infrastructure.

[chadwhitacre]

+1 from @ElijahLynn via Twitter.

[ElijahLynn]

Thanks Chad!

[zbynekwinkler]

+1

[chadwhitacre]

+1 from @eric-s-raymond at #1481 (comment).

[pjf]

+1 from yours truly. Many of my supporters are non-technical folk, and Google/Facebook are their most accessible means of using gittip.

[chadwhitacre]

+1 from @CCsolidarity on Twitter.

[ElijahLynn]

[rohitpaulk]

@ElijahLynn - We're aware of this and double checked the implementation from our side. Looks like google is taking a while to propagate the changes. IRC

If this isn't solved by tomorrow, we'll investigate further.

[chadwhitacre]

Reopening till the bugs are squished.

I've configured the app and am not seeing the 401 anymore. Now I get a 500:

Internal Server Error, program!
google lookup failed with 403

[rohitpaulk]

Are you sure you've added the Google+ API?

[chadwhitacre]

That did it! 💃

[ElijahLynn]

Works great now! Plus I really like how if you sign in with it and realize you need to link it to your other account you just sign up and link it and it asks you if you want to transfer it and it gives you a screenshot of how it will look, excellent UX!!!

[chadwhitacre]

Thanks @ElijahLynn! Glad it worked for you! :-)