This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
form to directly jump to a personal page #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
added a commit
that referenced
this pull request
Jun 5, 2012
form to directly jump to a personal page
|
I tweaked this a bit in c895d80 and 3090b32, and have deployed it as version 1.0.19: https://www.gittip.com/. |
This was referenced Jun 15, 2012
chadwhitacre
added a commit
that referenced
this pull request
Jan 9, 2013
I wrote Embed #2 to update every 30 seconds or so, but that creates more traffic than it's worth.
chadwhitacre
added a commit
that referenced
this pull request
Jan 30, 2013
First this fixes a bug where XHR wasn't handled properly; apparently
it's xhr.onreadystatechange, not .readystatechange. Then we switch to
data-gittip-{base,username} for the data attributes, to make it clearer
for the user. Lastly roll this out as the new code for Embed #2 on the
profile page.
Closed
chadwhitacre
added a commit
that referenced
this pull request
Dec 15, 2016
We added this way back in our first pull request, #2. As it suggests there, this was in lieu of a real search feature. I think we should remove it because: - We no longer focus on individuals through their social network accounts - We have a real search feature - This clutters up the search page - It's sugar for going to /on/twitter/foo/ directly; you can still get there
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
You project is interesting.
But the first time I landed on the page I felt something strange because you only had a fixed list of people to tip. (Initially it also made me think the whole thing was a scam).
It's a psycological problem until you find out that you can type whichever name you want in the url and you understand that you can tip anybody if you want.
So this is my proposal (not real code, just an idea, "a pull request is better than a thousand words"). I didn't test it since I had troubles starting up the environment and sorry I don't have a lot of time right now; probably it won't work.