This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Balanced URL changed again? #2249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It didn't change again. We have two URL formats in our database. See #2085. |
|
What needs to be done then? |
|
Closing in favor of #2085. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values being returned from Postgres for
have changed. This commit adjusts the Gittip code to use these new values correctly.
Um, how the hell does this happen?
When I store a value in a persistent store, such as a database, I expect that value to stay there until some event occurs to change it. Looking
balanced_customer_hreffor myself, I see that the value has changed. I, as a Gittip user, have not changed my credit card info in well over a year.At a very high level, this is what scares me the most about the Gittip architecture. We do not treat data as something to be saved. Our data changes all the time and we have only occasional bits of tracking and history to know what changed when and why. This is the main thing preventing me from contributing more to Gittip. I do not want to add to the mess.