This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Fix payday #2374
Merged
Fix payday #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -258,7 +258,32 @@ def tip(tippee, amount): | |||
| , pachinko=True | |||
| ) | |||
|
|
|||
| for take in participant.get_current_takes(): | |||
| takes = self.db.all(""" | |||
There was a problem hiding this comment.
I think it'd be good to have a comment explaining this query in the code
| @@ -235,10 +235,10 @@ def payin(self, ts_start, participants): | |||
|
|
|||
| def pachinko(self, ts_start, participants): | |||
| i = 0 | |||
| for i, (participant, foo, bar) in enumerate(participants, start=1): | |||
There was a problem hiding this comment.
Ah, I see: we are ignoring tips and transfers anyway in the pachinko loop.
There was a problem hiding this comment.
So we don't need to use genparticipants to knit those into the result of get_participants.
- Add a for_payday parameter to get_current_takes, on the pattern of Participant.get_tips_and_total. I believe this adequately reproduces the semantics of the inline takes query currently on the fix-payday branch. - Teach genparticipants about the different loops, harmonizing the semantics of that generator in the various loop cases. Now it knits in different extra info based on the loop: tips and total for payin/payout, takes for pachinko. My goal here is to provide a consistent implementation of the several payday loops.
Now that get_takes takes a for_payday its no longer necessarily *current* takes. Calling it get_takes harmonizes better with get_tips_and_total.
It's no longer true (if it ever was) that we see new tips and takes when rerunning payday after a crash.
Simplify SQL construction.
Closed
refactor the fix for duplicate pachinko transfers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to restart payday when it fails in the middle of pachinko, without creating duplicate transfers. #2362